Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

feat: Force quit rocksdb worker threads upon dropping. #734

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jsantell
Copy link
Contributor

No description provided.

Copy link
Contributor

Test flake analysis

status platform features toolchain
🟢 macos-13 test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers stable
🟡 ubuntu-latest test-kubo,headers nightly
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟡 macos-13 test-kubo,headers stable
🟢 windows-latest test-kubo,headers stable

Flake summary for ubuntu-latest, test-kubo,headers, nightly

     Summary [  43.078s] 176 tests run: 176 passed (1 flaky), 1 skipped
   FLAKY 2/6 [   1.801s] noosphere-ns dht::node::test::test_dhtnode_bootstrap

Flake summary for macos-13, test-kubo,headers, stable

     Summary [ 139.145s] 176 tests run: 176 passed (1 flaky), 1 skipped
   FLAKY 2/6 [  58.360s] noosphere::distributed_stress latency::clients_can_sync_when_there_is_a_lot_of_content

@cdata
Copy link
Collaborator

cdata commented Jan 9, 2024

@jsantell can you provide some commentary on the motivation of this change? Most of the context is phased out of my brain from holidays.

@jsantell
Copy link
Contributor Author

Suspecting a possible culprit for the lock inbetween windowing: subconsciousnetwork/subconscious#1008 -- not sure of the current state there, but this at least reasonably maps rocksdb resource lifetimes to the rust structures (originally elided due to stack overflow in early integration tests and a one off comment somewhere suspecting the two related)

Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdata cdata merged commit 21bf742 into main Jan 16, 2024
32 checks passed
@cdata cdata deleted the rocksdb-cancel-work branch January 16, 2024 20:07
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants